-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package recipe for CMake Integration #2460
Conversation
….cmake files are packaged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mjohnsonwy!
@mjohnsonwy are you also gonna submit a PR for the Conan Center recipe here? Not quite sure what the process is.. |
@gegles I can look into that. I'm not sure what the process is either... |
@gegles: Turns out there's a new revision of the Catch2 Conan recipe already on Conan Center, as of 3 days ago. Installing the latest revision fixes this issue. Looks like that recipe handles it a bit differently, but the effects are the same. Edit: The correct package revision is |
This is great @mjohnsonwy ! I tried a few days ago and had not seen the change since. After updating, it now works for me. It's too bad there is this redundancy between the recipe here and the conan center recipe though. Cheers. G. |
Codecov Report
@@ Coverage Diff @@
## devel #2460 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 159 159
Lines 7512 7512
=======================================
Hits 6875 6875
Misses 637 637 |
Thanks, lgtm. |
Description
Updated the Conan package recipe to add
lib/cmake/Catch2
tocpp_info.components["catch2base"].builddirs
. This ensures that Conan properly copies theextras/Catch.cmake
andextras/CatchAddTests.cmake
to the package, which allows CMake intregration to work.Tested locally with
conan create . 3.0.1@local/test
and verified it works on Mac OS 11.6 and Windows 10.GitHub Issues
Closes #2455